Skip to content

chore: Bump the Rust crates to the released 0.8.0 - #2169

Merged
omesser merged 1 commit into
mainfrom
chore/bump-crate-versions
Nov 9, 2026
Merged

omesser merged 1 commit into
mainfrom
chore/bump-crate-versions

Conversation

@omesser

@omesser omesser commented Nov 9, 2026

Copy link
Copy Markdown
Owner

Why

The workspace has said 0.1.0 since #33, while releases have reached v0.8.0. The release workflow stamps the tag on the bundles through Tauri's --config, but that doesn't reach env!("CARGO_PKG_VERSION"). From reading the workflow, a released Fidget should still report 0.1.0 in its ACP client info and MCP serverInfo. I didn't confirm that on a release build.

What changed

[workspace.package] version goes from 0.1.0 to 0.8.0, the latest release, and Cargo.lock follows for the four workspace crates. No dependency moved.

src-tauri/tauri.conf.json stays at 0.1.0: release.yml overrides it, and its comment says git names the version that ships.

How to verify

  • cargo check --workspace --all-targets passes, and so do the fidget-mcp-server tests and the mcp_http tests in fidget, on Windows.
  • git diff main -- Cargo.lock shows only the four fidget* version lines.
  • pre-commit passes, with ast-grep, ast-grep-rule-tests and oxlint skipped because they won't install on this machine.

Notes

Nothing automates this, so each later release needs the same small bump after it publishes.

🤖 Generated with Claude Code

— Claude Code, on @omesser's behalf.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@omesser omesser added the maintenance Dependency and tooling upkeep label Nov 9, 2026

@omesser omesser left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Soft Open

Tip: 24690dbc

What changed

  • Workspace version: [workspace.package] version goes from 0.1.0 to 0.8.0, and Cargo.lock follows for the four fidget* crates only.

What is wrong

  • Root cause stays open: release.yml already computes the shipping version in the ver step but only passes it to Tauri through --config. env!("CARGO_PKG_VERSION") in acp_wire.rs and mcp_http.rs keeps reading Cargo.toml, so v0.8.1 will again report 0.8.0 until someone remembers a manual bump, and every -dev.g<sha> build reports a release it isn't.

Soft-FIX

  • Stamp Cargo from the release step: have release.yml write steps.ver.outputs.version into [workspace.package] version before the Tauri build, or have the two call sites read a build env the step sets, so the ACP client info and MCP serverInfo always match the bundle. Keeping 0.8.0 as the checked-in baseline is fine.

Non-blocking

  • tauri.conf.json: with the release step stamping both, its 0.1.0 could move to 0.8.0 too so local builds agree with Cargo.toml.

Verified cargo metadata --locked accepts the lockfile and the only CARGO_PKG_VERSION readers are the two call sites above.

— Cursor agent (Architect), on @omesser's behalf.

@omesser
omesser merged commit 492c8b0 into main Nov 9, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Dependency and tooling upkeep

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant